alamb commented on code in PR #9755:
URL: https://github.com/apache/arrow-rs/pull/9755#discussion_r3342589227
##########
arrow-select/src/coalesce/byte_view.rs:
##########
@@ -111,6 +112,79 @@ impl<B: ByteViewType> InProgressByteViewArray<B> {
self.completed.push(next_buffer.into());
}
+ fn append_inline_views_by_filter(&mut self, views: &[u128], filter:
&FilterPredicate) {
Review Comment:
It appears this code is not covered by existing tests:
I ran code coverage using llvm-cov:
```shell
cargo llvm-cov --html test -p arrow-select
```
Here is the report
<img width="977" height="1169" alt="Image"
src="https://github.com/user-attachments/assets/df8f8d13-e090-4ae4-8d76-efd8f0a2edae";
/>
##########
arrow-select/src/coalesce/byte_view.rs:
##########
@@ -111,6 +112,79 @@ impl<B: ByteViewType> InProgressByteViewArray<B> {
self.completed.push(next_buffer.into());
}
+ fn append_inline_views_by_filter(&mut self, views: &[u128], filter:
&FilterPredicate) {
Review Comment:
It appears this code is not covered by existing tests:
I ran code coverage using llvm-cov:
```shell
cargo llvm-cov --html test -p arrow-select
```
Here is the report
<img width="977" height="1169" alt="Image"
src="https://github.com/user-attachments/assets/df8f8d13-e090-4ae4-8d76-efd8f0a2edae";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
