alamb commented on code in PR #10049:
URL: https://github.com/apache/arrow-rs/pull/10049#discussion_r3342581133
##########
arrow-select/src/filter.rs:
##########
@@ -569,33 +581,6 @@ where
RunArray::try_new(&run_ends, &values)
}
-/// Computes a new null mask for `data` based on `predicate`
-///
-/// If the predicate selected no null-rows, returns `None`, otherwise returns
-/// `Some((null_count, null_buffer))` where `null_count` is the number of nulls
-/// in the filtered output, and `null_buffer` is the filtered null buffer
-///
-fn filter_null_mask(
Review Comment:
The idea is to just inline this into the `FilterPredicate::filter_nulls` to
make the API simpler (as it already requires a `predicate: &FilterPredicate`
anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
