theirix commented on code in PR #9418:
URL: https://github.com/apache/arrow-rs/pull/9418#discussion_r3344425298
##########
arrow-buffer/src/bigint/mod.rs:
##########
@@ -807,6 +807,55 @@ impl Shr<u8> for i256 {
}
}
+impl WrappingShl for i256 {
+ #[inline]
+ fn wrapping_shl(&self, rhs: u32) -> i256 {
+ // Mask the higher-order bits
Review Comment:
Agree, it explains the shifting logic better. Added the changes to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
