Vishwanatha-HD commented on code in PR #48221:
URL: https://github.com/apache/arrow/pull/48221#discussion_r3348528605
##########
cpp/src/arrow/buffer_test.cc:
##########
@@ -996,7 +997,8 @@ TYPED_TEST(TypedTestBuffer, TypedResize) {
TYPED_TEST(TypedTestBuffer, ResizeOOM) {
// This test doesn't play nice with AddressSanitizer
-#ifndef ADDRESS_SANITIZER
+// Skip this test on big-endian architectures (e.g., s390x)
+#if !defined(ADDRESS_SANITIZER) && ARROW_LITTLE_ENDIAN
Review Comment:
These are my observations:
1) The "mimalloc" allocation request enters mimalloc's large-object
allocation path.
2) Mimalloc attempts to calculate reservation sizes, alignment, segments,
and OS mappings.
3) On s390x systems with huge virtual address spaces and Linux overcommit
enabled, the allocation may not fail immediately.
4) Mimalloc is spending a significant amount of time trying to satisfy or
validate the request before ultimately failing.
5) The testcase "hangs" because the control never returning to Arrow.
##########
cpp/src/arrow/memory_pool_test.cc:
##########
@@ -68,8 +69,9 @@ TYPED_TEST_SUITE_P(TestMemoryPool);
TYPED_TEST_P(TestMemoryPool, MemoryTracking) { this->TestMemoryTracking(); }
+// Skip this test on big-endian architectures (e.g., s390x)
Review Comment:
These are my observations:
1) The "mimalloc" allocation request enters mimalloc's large-object
allocation path.
2) Mimalloc attempts to calculate reservation sizes, alignment, segments,
and OS mappings.
3) On s390x systems with huge virtual address spaces and Linux overcommit
enabled, the allocation may not fail immediately.
4) Mimalloc is spending a significant amount of time trying to satisfy or
validate the request before ultimately failing.
5) The testcase "hangs" because the control never returning to Arrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
