alamb opened a new pull request, #10056: URL: https://github.com/apache/arrow-rs/pull/10056
# Which issue does this PR close? Documentation follow-up for #9755 (`arrow-select: fuse inline Utf8View/BinaryView filter coalescing`). > [!NOTE] > This branch is **stacked on top of #9755** — that PR is not yet merged to `main`, so the diff here also shows its feature commit. The contribution in this PR is the **single docs commit** on top (`arrow-select/src/filter.rs` only); the intent is to fold it into #9755 (or merge alongside it). # Rationale for this change The `pub(crate)` filtering APIs added alongside the fused inline-view path (`FilterSelection`, `FilterIterator`, and `FilterPredicate::selection`) had little explanation of *why* they exist or how to use them. This adds that rationale. # What changes are included in this PR? Comments only — no code changes: - `FilterSelection`: note that it borrows the predicate's internal indices/slices so the same predicate can drive several arrays without cloning, and document each variant (`None`, `All`, `Slices`, `Indices`). - `FilterIterator`: clarify the materialized-vs-lazy split (an iterator over a precomputed list vs. one that derives selected rows from the predicate on the fly), and document `for_each` / `try_for_each` (the latter short-circuits on the first `Err`). - `FilterPredicate`: document the `strategy` field and the `selection()` accessor. # Are there any user-facing changes? No (the documented items are `pub(crate)`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
