Jimexist commented on a change in pull request #303:
URL: https://github.com/apache/arrow-datafusion/pull/303#discussion_r629927595
##########
File path: datafusion/src/physical_plan/functions.rs
##########
@@ -1373,20 +1370,26 @@ impl PhysicalExpr for ScalarFunctionExpr {
}
fn evaluate(&self, batch: &RecordBatch) -> Result<ColumnarValue> {
- // evaluate the arguments
- let inputs = self
- .args
- .iter()
- .map(|e| e.evaluate(batch))
- .collect::<Result<Vec<_>>>()?;
+ // evaluate the arguments, if there are no arguments we'll instead
pass in a null array of
+ // batch size (as a convention)
+ let inputs = match self.args.len() {
+ 0 => vec![ColumnarValue::Array(Arc::new(NullArray::new(
Review comment:
the alternative is to drastically change the signature of scalar
functions. it confess compared with that this is cleaner (but a bit hacky).
will change to use a scalar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
