lesam commented on code in PR #716:
URL: https://github.com/apache/arrow-go/pull/716#discussion_r3356737625


##########
arrow/compute/selection.go:
##########
@@ -485,6 +485,40 @@ func structFilter(ctx *exec.KernelCtx, batch 
*exec.ExecSpan, out *exec.ExecResul
        return nil
 }
 
+
+// dictionaryFilter is a special case for filtering a dictionary array
+//
+// The implementation uses the 'dictionaryTake' implementation.
+func dictionaryFilter(ctx *exec.KernelCtx, batch *exec.ExecSpan, out 
*exec.ExecResult) error {

Review Comment:
   If you don't mind I think I will leave this to a follow-up - FWIW I was 
mirroring structFilter that also does bool -> indices -> Take



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to