Copilot commented on code in PR #50107:
URL: https://github.com/apache/arrow/pull/50107#discussion_r3363930597
##########
python/pyarrow/tests/test_schema.py:
##########
@@ -52,6 +52,11 @@ def test_type_integers():
assert str(t) == name
[email protected]
+def test_extension_type_to_pandas_dtype():
+ pa.fixed_shape_tensor(pa.float32(),[2,2]).to_pandas_dtype()
Review Comment:
PEP8 spacing: add a space after the comma in the shape list for
readability/consistency (`[2, 2]`).
##########
python/pyarrow/tests/test_schema.py:
##########
@@ -52,6 +52,11 @@ def test_type_integers():
assert str(t) == name
[email protected]
+def test_extension_type_to_pandas_dtype():
+ pa.fixed_shape_tensor(pa.float32(),[2,2]).to_pandas_dtype()
Review Comment:
This test currently only calls `to_pandas_dtype()` without asserting
anything about the result (or expected exception). That means it will pass even
if the method returns an incorrect dtype, and it won’t clearly communicate
intended behavior. Please assert the returned dtype (type/value) or, if the
intended contract is that it’s unsupported, use `pytest.raises(...)` to assert
the expected exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
