dmitry-chirkov-dremio commented on code in PR #50112:
URL: https://github.com/apache/arrow/pull/50112#discussion_r3365960922
##########
cpp/src/gandiva/precompiled/time.cc:
##########
@@ -268,7 +268,12 @@ static const int WEEK_LEN[] = {6, 6, 7, 9, 8, 6, 8};
}
\
}
\
if (dateSearch == 0) {
\
- gdv_fn_context_set_error_msg(context, "The weekday in this entry is
invalid"); \
+ char err_msg[160];
\
+ snprintf(err_msg, sizeof(err_msg),
\
+ "NEXT_DAY: '%.*s' is not a recognized weekday "
\
+ "(expected MON|TUE|WED|THU|FRI|SAT|SUN)",
\
Review Comment:
Based on tests function accepts two character version, three character
versions as well as whole day so error is not correct/complete.
Lets also add a test to show if comparison is case sensitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
