theirix opened a new pull request, #10088: URL: https://github.com/apache/arrow-rs/pull/10088
# Which issue does this PR close? - Closes #10087. # Rationale for this change Following up on #9417, there are a few missing numeric traits for i256 from num-traits: Most likely, it brings us to the most conformant state, since https://docs.rs/num-traits/latest/num_traits/int/trait.PrimInt.html cannot be implemented because of [`NumCast`](https://docs.rs/num-traits/latest/num_traits/cast/trait.NumCast.html#tymethod.from) trait - it is not compatible with arrow-buffer's `std::convert::From` trait implementations (they return `Self`, not `Option<Self>`) # What changes are included in this PR? Traits: - SaturatingAdd, SaturatingSub, SaturatingMul - CheckedShl, CheckedShr - Not - ConstOne, ConstZero # Are these changes tested? Existing and new unit tests # Are there any user-facing changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
