HippoBaro commented on code in PR #9848:
URL: https://github.com/apache/arrow-rs/pull/9848#discussion_r3368609706
##########
parquet/src/arrow/array_reader/builder.rs:
##########
@@ -230,12 +234,17 @@ impl<'a> ArrayReaderBuilder<'a> {
&self,
field: &ParquetField,
mask: &ProjectionMask,
+ padding_threshold: Option<i16>,
) -> Result<Option<Box<dyn ArrayReader>>> {
let children = field.children().unwrap();
assert_eq!(children.len(), 2);
- let key_reader = self.build_reader(&children[0], mask)?;
- let value_reader = self.build_reader(&children[1], mask)?;
+ // The map is internally List(Struct(key, value)). The key/value
+ // readers are children of the struct inside the list, so their
+ // padding threshold is the map's (= list's) def_level.
+ let child_threshold = Some(field.def_level);
Review Comment:
See https://github.com/apache/arrow-rs/pull/10089. Thanks for the suggestion
🙇
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
