Copilot commented on code in PR #50120:
URL: https://github.com/apache/arrow/pull/50120#discussion_r3369175596
##########
r/src/compute-exec.cpp:
##########
@@ -48,8 +48,10 @@ std::shared_ptr<acero::ExecPlan> ExecPlan_create(bool
use_threads) {
// TODO(weston) using gc_context() in this way is deprecated. Once ordering
has
// been added we can probably entirely remove all reference to ExecPlan from
R
// in favor of DeclarationToXyz
- auto plan =
- ValueOrStop(acero::ExecPlan::Make(use_threads ? &threaded_context :
gc_context()));
+ acero::QueryOptions query_options;
+ query_options.unaligned_buffer_handling =
acero::UnalignedBufferHandling::kReallocate;
+ auto plan = ValueOrStop(acero::ExecPlan::Make(
+ std::move(query_options), use_threads ? &threaded_context :
gc_context()));
Review Comment:
PR description says there are no user-facing changes, but this change alters
runtime behavior by changing Acero’s unaligned buffer policy to kReallocate.
That will suppress the previous warning and may add extra copies/allocations
for unaligned input; it’s worth reflecting that in the PR description (and/or
release notes if applicable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
