lidavidm commented on code in PR #838:
URL: https://github.com/apache/arrow-go/pull/838#discussion_r3370494207


##########
parquet/pqarrow/column_readers.go:
##########
@@ -488,6 +488,18 @@ func (lr *listReader) BuildArray(lenBound int64) 
(*arrow.Chunked, error) {
                buffers[0] = validityBuffer
        }
 
+       if lr.field.Type.ID() == arrow.LARGE_LIST {

Review Comment:
   Done, though there's a slightly awkward construction to get the max value of 
the offset type; I see there's a helper inside the kernels code, but not sure 
if there's a good place to pull that out so it's just inlined for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to