Rich-T-kid commented on issue #10017:
URL: https://github.com/apache/arrow-rs/issues/10017#issuecomment-4645053682
It may make more sense to split this up into a separate PR for each
sub-directory. I can imagine it'd be hard to review all of these changes in 1
PR. firstly all callsites that assume that the values array will stay in tack
need to be changed, then a final PR that changes
````
---
```
pub fn slice(&self, offset: usize, length: usize) -> Self {
Self {
data_type: self.data_type.clone(),
run_ends: self.run_ends.slice(offset, length),
values: self.values.clone(),
}
}
```
to
```
pub fn slice(&self, offset: usize, length: usize) -> Self {
Self {
data_type: self.data_type.clone(),
run_ends: self.run_ends.slice(offset, length),
values: self.values.slice(offset, length),
}
}
```
````
then this issue will be considered closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
