robsdedude commented on code in PR #48618: URL: https://github.com/apache/arrow/pull/48618#discussion_r3371590167
########## python/pyarrow/py.typed: ########## Review Comment: I think adding a `py.typed` marker to the package before all public APIs are typed (even just with a whole bunch of `Any`s) wasn't ideal. Downstream users will now see a bunch of typing errors because type checkers now assume that pyarrow provides type hints that can be relied upon. In my case, I'm seeing `mypy` complain about `Module has no attribute "count" [attr-defined]` where the module in question is `pyarrow.compute`. Please consider either removing the marker until type hints are ready or to make sure all public APIs exist (at least as `def xyz(*args: Any, **kwargs: Any) -> Any` stubs). Or apply the same `__getatrr__` placeholder to all modules, not just the top-level module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
