metsw24-max opened a new pull request, #50124: URL: https://github.com/apache/arrow/pull/50124
**Out-of-range argument passed to ctype functions** The Gandiva string and time helpers feed raw `char` bytes into `isdigit`/`isxdigit`/`isalpha`/`toupper`. Where `char` is signed, any byte above 0x7f (so any multi-byte UTF-8 value in untrusted column data) is sign-extended to a negative `int`, which sits outside the `unsigned char`/`EOF` domain those functions are defined for. glibc tolerates it, but a strict ctype table indexes before its lookup array. Cast each argument to `unsigned char` at the call site, the way `gdv_function_stubs.cc` already does. Reviewer note: this is the same swept across both files so no instance is left behind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
