Copilot commented on code in PR #49710:
URL: https://github.com/apache/arrow/pull/49710#discussion_r3372655164
##########
r/tests/testthat/test-Table.R:
##########
@@ -371,6 +371,26 @@ test_that("Can create table with specific dictionary
types", {
}
})
+test_that("Table converts dictionary arrays with uint32/int64/uint64 index
types back to R", {
+ fact <- example_data[, "fct"]
+
+ tab_uint32 <- Table$create(fact, schema = schema(fct = dictionary(uint32(),
utf8())))
+ expect_equal(tab_uint32$schema, schema(fct = dictionary(uint32(), utf8())))
Review Comment:
This new test verifies int64 dictionary indices round-trip, but the
preceding test "Can create table with specific dictionary types" still contains
a TODO/conditional that skips `expect_equal_data_frame()` for `int64()` and
implies downcasting isn’t supported. Now that int64 conversion is supported,
that earlier conditional and comment are stale and reduce test clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
