stephenashton-dhsc commented on PR #49937:
URL: https://github.com/apache/arrow/pull/49937#issuecomment-4648296560

   > > > > I think this has caused an unintended consequence.
   > > > > The following code runs under the CRAN version of arrow without 
issue:
   > > > > ```
   > > > > library(arrow)
   > > > > library(dplyr)
   > > > > 
   > > > > starwars |> mutate(sex = factor(sex, ordered = TRUE)) |> 
write_parquet(sink = tempfile())
   > > > > ```
   > > > > 
   > > > > 
   > > > >     
   > > > >       
   > > > >     
   > > > > 
   > > > >       
   > > > >     
   > > > > 
   > > > >     
   > > > >   
   > > > > However, under this PR, it returns the following error:
   > > > > ```
   > > > > Error: Invalid: Column data for field 7 with type 
dictionary<values=string, indices=int8, ordered=0> is inconsistent with schema 
dictionary<values=string, indices=int8, ordered=1>
   > > > > ```
   > > > > 
   > > > > 
   > > > >     
   > > > >       
   > > > >     
   > > > > 
   > > > >       
   > > > >     
   > > > > 
   > > > >     
   > > > >   
   > > > > Would it be possible to resolve this?
   > > > 
   > > > 
   > > > Thanks for the review @stephenashton-dhsc .Would you mind sharing a 
bit more about the steps you took to build Arrow to get that error? I tried it 
myself locally but I can't reproduce your error, so it might be that you had a 
mismatch between R package and C++ library version, though it'd be good to be 
sure.
   > > 
   > > 
   > > I just did a build/install using 
`pak::pkg_install("apache/arrow/r#49937")`.
   > > I'll retest under 
[29dfbc7](https://github.com/apache/arrow/pull/49937/commits/29dfbc730de2ed1242b3f6c821bc57a6b30b98eb)
 now, just in case that has resolved the issue.
   > 
   > Aha, AFAIK `pak::pkg_install()` won't rebuild the C++ libraries and will 
only rebuild the R package but with existing C++ libraries you have installed. 
If you wanted to test this PR out like that you'd need to do a full rebuild of 
the Arrow C++ library before installing the R package, as I've modified C++ in 
this PR. The docs for that are 
[here](https://arrow.apache.org/docs/r/articles/developers/setup.html).
   > 
   > What is it that you're trying to do? If you're trying to use the 
functionality implemented here, if you wait for the PR to merge, it'll be there 
in the nightly Arrow binaries later, which you can install using 
`arrow::install_arrow(nightly=TRUE)` which is a lot easier than doing a full 
dev build.
   
   Ah - my mistake then. Apologies!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to