AlenkaF commented on PR #41870: URL: https://github.com/apache/arrow/pull/41870#issuecomment-4649450155
I have implemented a change similar to what was proposed in https://github.com/apache/arrow/pull/41870#pullrequestreview-4401682178 (using `std::numeric_limits<util::Float16>::quiet_NaN()`) and am not sure if this fits in this PR or if it falls under `float16` support as a follow-up. If the conversion specifically outputs `quiet NaN` in the `float16` case I can't use `Tensor::Equals` in the tests as the [float16 dtype is not yet supported](https://github.com/apache/arrow/blob/68fb4644eabebca683b37ac9500e742da75585df/cpp/src/arrow/compare.cc#L1312). Claude advised me to inspect raw buffers. Not sure about it, really =) The change: https://github.com/apache/arrow/pull/41870/changes/fd2f20dd0dc8ecf6d9fe96c8c7c1c48b46f53f4f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
