Copilot commented on code in PR #50128:
URL: https://github.com/apache/arrow/pull/50128#discussion_r3374600080
##########
cpp/src/arrow/filesystem/s3fs_module_test.cc:
##########
@@ -82,4 +83,10 @@ TEST(S3Test, FromUri) {
"&allow_bucket_creation=0&allow_bucket_deletion=0");
}
+TEST(S3Test, FromUriRejectsUnknownOptions) {
+ std::vector<std::pair<std::string, std::any>> options{{"some_option", 1}};
+ EXPECT_RAISES_WITH_MESSAGE_THAT(Invalid, ::testing::HasSubstr("Unexpected
option"),
+ FileSystemFromUri("s3://bucket/key",
options));
+}
+
Review Comment:
The new S3 options support is only tested for the negative case (rejecting
unknown keys). There is no test that valid keys (e.g., access_key/secret_key)
are actually consumed and affect the resulting filesystem/options, so a
regression where options are ignored would still pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
