alamb commented on PR #10074:
URL: https://github.com/apache/arrow-rs/pull/10074#issuecomment-4653153296
> Thanks @alamb !
>
> Do you think it'd be better to export this as public code instead of a
docstring? Then the docstring could show using the code and the code would be a
good example that we can add tests to, etc.
I am torn about this -- the example implementation is really quite bad (does
many small I/Os, no buffering or prefetching, etc) so if we included it with
arrow-rs I think people would have a crappy experience. WIth an example at
least the crappy experience would be their own code (that they copy pasted...)
But now that I write that it seems a poor justification :think
> The only other note I'd add for the example is to write to a file instead
of an in-memory buffer. The destination being memory makes the argument for
spilling buffers to disk weaker IMO.
I don't quite follow this question. The example does write to a file
```rut
/// file: File,
```
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
