lidavidm commented on code in PR #1064:
URL: https://github.com/apache/arrow-java/pull/1064#discussion_r3377865726
##########
flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/client/ArrowFlightSqlClientHandler.java:
##########
@@ -388,6 +388,14 @@ public interface PreparedStatement extends AutoCloseable {
*/
Schema getParameterSchema();
+ /**
+ * Gets whether this {@link PreparedStatement} is an update statement.
+ *
+ * @return {@code true} if this is an update statement, {@code false} if
it's a query, or {@code
+ * null} if the server did not provide this information.
+ */
+ Boolean isUpdate();
Review Comment:
```suggestion
@Nullable Boolean isUpdate();
```
##########
flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/utils/MockFlightSqlProducer.java:
##########
Review Comment:
Why do we need the V2? Maybe we can have an overload that takes `@Nullable
Boolean` or something to put in the isUpdateMap?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
