Rich-T-kid commented on code in PR #10044:
URL: https://github.com/apache/arrow-rs/pull/10044#discussion_r3381083168
##########
arrow-ipc/src/writer.rs:
##########
@@ -1807,7 +1930,7 @@ fn get_or_truncate_buffer(array_data: &ArrayData) ->
&[u8] {
fn write_array_data(
array_data: &ArrayData,
buffers: &mut Vec<crate::Buffer>,
- arrow_data: &mut Vec<u8>,
+ sink: &mut BufferSink<'_>,
nodes: &mut Vec<crate::FieldNode>,
Review Comment:
this makes sense to me, I've renamed it to `IpcBodySink` to help new readers
understand the distinction better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
