pitrou commented on code in PR #50030:
URL: https://github.com/apache/arrow/pull/50030#discussion_r3381526154
##########
cpp/src/parquet/bloom_filter_test.cc:
##########
@@ -434,5 +443,85 @@ TYPED_TEST(TestBatchBloomFilter, Basic) {
AssertBufferEqual(*buffer, *batch_insert_buffer);
}
+// Guards against silent drift between the baseline and AVX2 probe bodies --
+// DynamicDispatch only runs one of them per host.
+#if defined(ARROW_HAVE_RUNTIME_AVX2)
+namespace {
+
+// Mirror of BlockSplitBloomFilter::kBitsSetPerBlock (private to the class).
+constexpr int kBitsSetPerBlock = 8;
Review Comment:
Well, why not make it public in the class? This would avoid hard-coding it
in multiple places (in `cpp/src/parquet/bloom_filter_block_impl_internal.h` as
well).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
