alamb commented on code in PR #10084:
URL: https://github.com/apache/arrow-rs/pull/10084#discussion_r3383654124
##########
parquet/benches/arrow_writer.rs:
##########
@@ -332,6 +332,54 @@ fn create_struct_bench_batch(size: usize, null_density:
f32) -> Result<RecordBat
)?)
}
+fn create_nested_list_bench_batch(size: usize, null_density: f32) ->
Result<RecordBatch> {
+ // List<List<Int32>> — exercises the nested repetition (non-batched) path
+ let fields = vec![Field::new(
+ "_1",
Review Comment:
I think "item" is also commonly used
##########
parquet/benches/arrow_writer.rs:
##########
@@ -491,6 +539,12 @@ fn create_batches() -> Vec<(&'static str, RecordBatch)> {
let batch = create_struct_bench_batch(BATCH_SIZE, 1.0).unwrap();
batches.push(("struct_all_null", batch));
+ let batch = create_nested_list_bench_batch(BATCH_SIZE, 0.25).unwrap();
Review Comment:
I ran it just to be sure it worked, and it seems to work well
```shell
andrewlamb@Andrews-MacBook-Pro-3:~/Software/arrow-rs2$ cargo bench --bench
arrow_writer -- list_nested
...
Benchmarking list_nested/bloom_filter: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 12.7s, or reduce sample count to 30.
list_nested/bloom_filter
time: [122.62 ms 123.17 ms 123.76 ms]
thrpt: [233.14 MiB/s 234.26 MiB/s 235.32 MiB/s]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
