raulcd commented on PR #50044: URL: https://github.com/apache/arrow/pull/50044#issuecomment-4672017598
> Can `std::any` be easier to use for our bindings? If so, I don't object the `std::any` approach. Hi @kou I wasn't sure so I decided to take some time to investigate it. I've created this commit (https://github.com/apache/arrow/pull/50151/commits/acfc93977623148ca495decf6ef31c0a5a0d32d2) on top of this PR to test `std::any` bindings on R, Python and C GLib / Ruby. I've used Claude to help with the Ruby and R bindings but I've validated the test is exercised by producing a failing test first (TDD). All of the binding usages for `std::any` look quite ergonomic and easy to use. I've created a PR to exercise CI and demonstrate the bindings are green, can be seen here: - https://github.com/apache/arrow/pull/50151 So, in my opinion it is easy to use for our bindings, what are your thoughts on it? Note: A minor nit, we seem to have an `arrow::dataset::FileSystemFactoryOptions` and the new `arrow::fs::FileSystemFactoryOptions` forced me to alias on the Python bindings, maybe we want to rename the new one as this is the right time but not a big deal if we have to keep an alias. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
