adamreeve commented on code in PR #50150:
URL: https://github.com/apache/arrow/pull/50150#discussion_r3391542581
##########
cpp/src/parquet/arrow/fuzz_encoding_internal.cc:
##########
@@ -315,14 +316,19 @@ struct TypedFuzzEncoding {
auto reencoded_data = reencoded_buffer->template span_as<uint8_t>();
// Vary chunk sizes
for (const int chunk_size : chunk_sizes()) {
- ARROW_CHECK_OK(RunOnDecodedChunks(roundtrip_encoding_,
reencoded_data,
- chunk_size, compare_chunk));
+ RETURN_NOT_OK(RunOnDecodedChunks(roundtrip_encoding_, reencoded_data,
+ chunk_size, compare_chunk));
}
}
END_PARQUET_CATCH_EXCEPTIONS
Review Comment:
Just noticed that there is another behaviour change. Previously any Parquet
exceptions would be converted to a status code return value, but now they will
get checked below and treated as a fatal error. That seems appropriate though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
