kevinjqliu commented on code in PR #732: URL: https://github.com/apache/arrow-rs-object-store/pull/732#discussion_r3391555816
########## src/gcp/mod.rs: ########## @@ -66,6 +66,11 @@ mod credential; const STORE: &str = "GCS"; +// OrderedListing is supported by all GCP bucket types. Review Comment: ```suggestion // OrderedListing is supported by all GCP bucket types. // https://docs.cloud.google.com/storage/docs/listing-objects ``` ########## src/aws/mod.rs: ########## @@ -79,10 +79,16 @@ use crate::client::parts::Parts; use crate::list::{PaginatedListOptions, PaginatedListResult, PaginatedListStore}; pub use credential::{AwsAuthorizer, AwsCredential}; +/// OrderedListing capability depends on the bucket type, it's not enabled for directory bucket. Review Comment: ```suggestion /// OrderedListing capability depends on the bucket type, it's not enabled for directory bucket. /// https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html ``` ########## src/azure/mod.rs: ########## @@ -58,10 +58,16 @@ pub use credential::AzureCredential; const STORE: &str = "MicrosoftAzure"; +// OrderedListing capability is not supported by with Azure Storage Hierarchical Namespace is enabled. Review Comment: ```suggestion // OrderedListing capability is not supported by with Azure Storage Hierarchical Namespace is enabled. // https://learn.microsoft.com/en-us/rest/api/storageservices/list-blobs ``` ########## src/aws/builder.rs: ########## @@ -1500,6 +1522,7 @@ impl From<S3EncryptionHeaders> for HeaderMap { #[cfg(test)] Review Comment: nit: should we add the same tests for azure/gcp/memory? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
