alamb commented on code in PR #10111:
URL: https://github.com/apache/arrow-rs/pull/10111#discussion_r3392536684
##########
arrow-ipc/src/writer.rs:
##########
@@ -1945,29 +1949,28 @@ fn get_or_truncate_buffer(array_data: &ArrayData) ->
Buffer {
/// Recursively encodes `array_data` into its IPC representation.
///
/// Output goes to two separate channels:
-/// - `buffers` / `nodes`: IPC metadata (offsets, lengths, null counts) that
will be
-/// serialised into the flatbuffer `RecordBatch` header.
+/// - `meta`: accumulates IPC metadata (`nodes` and `buffers`) for the
flatbuffer header.
/// - `sink`: the raw Arrow data bytes that form the IPC message body.
-#[allow(clippy::too_many_arguments)]
fn write_array_data(
array_data: &ArrayData,
- buffers: &mut Vec<crate::Buffer>,
+ meta: &mut IpcMetadataBuilder,
sink: &mut IpcBodySink<'_>,
- nodes: &mut Vec<crate::FieldNode>,
offset: i64,
- num_rows: usize,
Review Comment:
that is a nice cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
