rluvaton commented on code in PR #10120: URL: https://github.com/apache/arrow-rs/pull/10120#discussion_r3397023713
########## arrow-array/src/array/list_array.rs: ########## @@ -38,7 +38,7 @@ use std::sync::Arc; /// [`StringArray`]: crate::array::StringArray /// [`LargeStringArray`]: crate::array::LargeStringArray pub trait OffsetSizeTrait: - ArrowNativeType + std::ops::AddAssign + Integer + num_traits::CheckedAdd + ArrowNativeType + std::ops::AddAssign + Integer + num_traits::CheckedAdd + num_traits::CheckedSub Review Comment: this is sealed since `ArrowNativeType` is sealed, so it is safe to add this here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
