Dandandan commented on pull request #319:
URL: https://github.com/apache/arrow-datafusion/pull/319#issuecomment-839150398
Hey @charlibot thanks for opening this PR - awesome.
I think it would be nice to have at least a simple test for running a `COUNT
DISTINCT (timestamp)` even if it is a simple
```SELECT COUNT(DISTINCT (CAST('2018-11-13T17:11:10.011' as timestamp)));`
Or with some more values to check whether the number of distinct values are
calculated correctly.
Currently we have some end-to-end tests in `datafusion/tests/sql.rs` - do
you feel like adding a test there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
