SAY-5 commented on PR #49832: URL: https://github.com/apache/arrow/pull/49832#issuecomment-4684066601
Thanks for the review. Addressed all four in 0334982: PrintMaxValue/PrintMinValue now loop over both the all-nines max (99999999999999999999999999999999999999) and the truncated bit-pattern value; FitsInPrecision uses max_nines + 1 instead of GetMaxValue; and the LeftShift comments now say the operands/shift were chosen so the expected result fits in kMaxPrecision, since FromString rejects wider literals, rather than implying the shift trims. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
