alamb commented on code in PR #743:
URL:
https://github.com/apache/arrow-rs-object-store/pull/743#discussion_r3398984217
##########
src/lib.rs:
##########
@@ -1865,16 +1879,42 @@ impl From<Attributes> for PutMultipartOptions {
}
/// Result for a put request
-#[derive(Debug, Clone, PartialEq, Eq)]
+#[derive(Debug, Clone)]
pub struct PutResult {
/// The unique identifier for the newly created object
///
/// <https://datatracker.ietf.org/doc/html/rfc9110#name-etag>
pub e_tag: Option<String>,
/// A version indicator for the newly created object
pub version: Option<String>,
+ /// Implementation-specific extensions. Intended for use by
[`ObjectStore`] implementations
+ /// that need to return context-specific information (like cache status)
from trait methods.
+ ///
+ /// HTTP-backed stores in this crate populate this with the extensions of
the HTTP
+ /// response, allowing custom HTTP middleware to propagate information to
callers.
+ ///
+ /// These extensions are excluded from [`PartialEq`] and [`Eq`].
+ pub extensions: Extensions,
Review Comment:
this is technically a breaking API change (but that is ok as we are about to
release a breaking release)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
