zeroshade commented on a change in pull request #10203:
URL: https://github.com/apache/arrow/pull/10203#discussion_r630564562
##########
File path: go/arrow/compare_test.go
##########
@@ -27,7 +27,7 @@ func TestTypeEqual(t *testing.T) {
checkMetadata bool
}{
{
- nil, nil, false, false,
+ nil, nil, true, false,
Review comment:
in order for simplifying the type comparison code when handling lists /
extension types I made a slight change to the logic here so that if you call
`TypeEqual` with both arguments being `nil` then it returns `true` that they
are equal. I was actually surprised when i found that this wasn't the case
already such that `TypeEqual(nil, nil)` previously returned false. Since it
simplified the code in other areas and also makes sense for nil to be equal to
nil for a call to `TypeEqual` I didn't see an issue with making that change
which only affected this one unit test which expected the false for two nils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
