Jefffrey commented on code in PR #9825:
URL: https://github.com/apache/arrow-rs/pull/9825#discussion_r3400316173
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -10951,6 +10963,56 @@ mod tests {
assert!(c.is_null(2));
}
+ #[test]
+ fn test_cast_date32_to_timestamp_us_overflow() {
+ const MAX_DAYS_MICROS: i32 = (i64::MAX / MICROSECONDS_IN_DAY) as i32;
+ let a = Date32Array::from(vec![Some(MAX_DAYS_MICROS),
Some(MAX_DAYS_MICROS + 1), None]);
+ let array = Arc::new(a) as ArrayRef;
+ let err = cast_with_options(
+ &array,
+ &DataType::Timestamp(TimeUnit::Microsecond, None),
+ &CastOptions {
+ safe: false,
+ format_options: FormatOptions::default(),
+ },
+ );
+ assert!(err.is_err());
+
+ let b = cast(&array, &DataType::Timestamp(TimeUnit::Microsecond,
None)).unwrap();
+ let c = b
+ .as_any()
+ .downcast_ref::<TimestampMicrosecondArray>()
+ .unwrap();
+ assert_eq!(9223372022400000000, c.value(0));
Review Comment:
```suggestion
let c = b.as_primitive::<TimestampMicrosecondType>();
assert_eq!(MAX_DAYS_MICROS as i64 * MICROSECONDS_IN_DAY, c.value(0));
```
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -10951,6 +10963,56 @@ mod tests {
assert!(c.is_null(2));
}
+ #[test]
+ fn test_cast_date32_to_timestamp_us_overflow() {
+ const MAX_DAYS_MICROS: i32 = (i64::MAX / MICROSECONDS_IN_DAY) as i32;
+ let a = Date32Array::from(vec![Some(MAX_DAYS_MICROS),
Some(MAX_DAYS_MICROS + 1), None]);
+ let array = Arc::new(a) as ArrayRef;
+ let err = cast_with_options(
+ &array,
+ &DataType::Timestamp(TimeUnit::Microsecond, None),
+ &CastOptions {
+ safe: false,
+ format_options: FormatOptions::default(),
+ },
+ );
+ assert!(err.is_err());
+
+ let b = cast(&array, &DataType::Timestamp(TimeUnit::Microsecond,
None)).unwrap();
+ let c = b
+ .as_any()
+ .downcast_ref::<TimestampMicrosecondArray>()
+ .unwrap();
+ assert_eq!(9223372022400000000, c.value(0));
+ assert!(c.is_null(1));
+ assert!(c.is_null(2));
+ }
+
+ #[test]
+ fn test_cast_date32_to_timestamp_ns_overflow() {
+ // 2262-04-11, 2062-04-12
+ let a = Date32Array::from(vec![Some(106751), Some(106752), None]);
+ let array = Arc::new(a) as ArrayRef;
+ let err = cast_with_options(
+ &array,
+ &DataType::Timestamp(TimeUnit::Nanosecond, None),
+ &CastOptions {
+ safe: false,
+ format_options: FormatOptions::default(),
+ },
+ );
+ assert!(err.is_err());
+
+ let b = cast(&array, &DataType::Timestamp(TimeUnit::Nanosecond,
None)).unwrap();
+ let c = b
+ .as_any()
+ .downcast_ref::<TimestampNanosecondArray>()
+ .unwrap();
+ assert_eq!(9223286400000000000, c.value(0));
Review Comment:
```suggestion
let upper_limit = 106_751;
let a = Date32Array::from(vec![Some(upper_limit), Some(upper_limit +
1), None]);
let array = Arc::new(a) as ArrayRef;
let err = cast_with_options(
&array,
&DataType::Timestamp(TimeUnit::Nanosecond, None),
&CastOptions {
safe: false,
format_options: FormatOptions::default(),
},
);
assert!(err.is_err());
let b = cast(&array, &DataType::Timestamp(TimeUnit::Nanosecond,
None)).unwrap();
let c = b.as_primitive::<TimestampNanosecondType>();
assert_eq!(upper_limit as i64 * NANOSECONDS_IN_DAY, c.value(0));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
