Barre commented on PR #643: URL: https://github.com/apache/arrow-rs-object-store/pull/643#issuecomment-4691106012
> This critique still stands: [#643 (review)](https://github.com/apache/arrow-rs-object-store/pull/643#pullrequestreview-4067116956) > > To keep this code maintainable, I think we need to encapsulate the `std::fs` operations with their respective fsync-calls into helper functions. Otherwise the risk of forgetting the fsync after the file system modification is just too high. I hope this looks better to you now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
