Jefffrey commented on issue #7208: URL: https://github.com/apache/arrow-rs/issues/7208#issuecomment-4696947522
It would be good to extend the date parsing to allow the extended format, as pointed out above https://github.com/apache/arrow-rs/blob/11a58ac3ec7086960376ed1b5da7dc75cad9da0d/arrow-cast/src/parse.rs#L615-L625 One thing to keep in mind is that the current code is very heavily based on the assumption that the date format is `YYYY-MM-DD` which leads to the offsets used for time parsing to assume these 10 characters for example: https://github.com/apache/arrow-rs/blob/11a58ac3ec7086960376ed1b5da7dc75cad9da0d/arrow-cast/src/parse.rs#L93-L110 - See line 103, shifts 11 since assuming a `YYYY-MM-DDT` format) For example here too: https://github.com/apache/arrow-rs/blob/11a58ac3ec7086960376ed1b5da7dc75cad9da0d/arrow-cast/src/parse.rs#L195-L197 So we'd need to fix this part of the time parsing too, ideally without too much effect on performance 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
