kevinjqliu commented on code in PR #742:
URL:
https://github.com/apache/arrow-rs-object-store/pull/742#discussion_r3410118103
##########
src/azure/client.rs:
##########
@@ -181,6 +199,30 @@ impl AzureConfig {
}
url
}
+
+ /// Whether a request built with this config must be treated as sensitive.
+ ///
+ /// The retry layer's `sensitive` flag suppresses the request URL from
+ /// error messages (see [`RetryableRequestBuilder::sensitive`]). For SAS
+ /// credentials this is load-bearing because the token is carried as URL
+ /// query parameters.
+ ///
+ /// CPK material lives in request *headers* (`x-ms-encryption-key` etc.),
+ /// not in the URL, so today's URL-only redaction does not actively hide
+ /// it. The flag is still set for CPK requests so that any future
+ /// expansion of the redaction surface (headers, response bodies) covers
+ /// CPK without further changes here, and so that operators have a single
+ /// "this request touches secret material" signal for both auth modes.
Review Comment:
```suggestion
/// CPK material lives in request *headers* (`x-ms-encryption-key` etc.),
/// not in the URL. Those header values are marked sensitive when added
to
/// the request, while this flag ensures retry/error formatting also
treats
/// the whole request as sensitive.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
