lidavidm commented on code in PR #852:
URL: https://github.com/apache/arrow-go/pull/852#discussion_r3410340185
##########
parquet/file/column_writer_types.gen.go.tmpl:
##########
@@ -269,6 +269,97 @@ func (w *{{.Name}}ColumnChunkWriter)
WriteBatchSpaced(values []{{.name}}, defLev
{{- end}}
}
+// WriteBatchSpacedWithError behaves like WriteBatchSpaced but reports a write
+// failure as an error instead of panicking or silently discarding it,
+// mirroring the error handling of WriteBatch. Prefer this method on write
+// paths whose sink may fail (for example a network-attached writer).
+func (w *{{.Name}}ColumnChunkWriter) WriteBatchSpacedWithError(values
[]{{.name}}, defLevels, repLevels []int16, validBits []byte, validBitsOffset
int64) (valueOffset int64, err error) {
Review Comment:
(1) Could we deprecate WriteBatchSpaced?
(2) Could WriteBatchSpaced be written in terms of WriteBatchSpacedWithError
instead of duplicating the code entirely? (e.g. defer to
WriteBatchSpacedWithError and panic if it returns an error)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
