paleolimbot commented on issue #796: URL: https://github.com/apache/arrow-nanoarrow/issues/796#issuecomment-4703971952
This was already patched in vcpkg; however, we need to upstream the patch https://github.com/microsoft/vcpkg/blob/80f9bcfa455e875d9c1bf7a7c6692d7e1e481061/ports/nanoarrow/fix-flatccrt-name.patch ``` diff --git a/CMakeLists.txt b/CMakeLists.txt index 2d80849..c414865 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -229,8 +229,10 @@ if(NANOARROW_IPC) set(NANOARROW_FLATCC_INCLUDE_DIR "${NANOARROW_FLATCC_ROOT_DIR}/include") add_library(flatccrt STATIC IMPORTED) set_target_properties(flatccrt - PROPERTIES IMPORTED_LOCATION - "${NANOARROW_FLATCC_ROOT_DIR}/lib/libflatccrt.a" + PROPERTIES IMPORTED_LOCATION_DEBUG + "${NANOARROW_FLATCC_ROOT_DIR}/debug/lib/${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt_d${CMAKE_STATIC_LIBRARY_SUFFIX}" + IMPORTED_LOCATION_RELEASE + "${NANOARROW_FLATCC_ROOT_DIR}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt${CMAKE_STATIC_LIBRARY_SUFFIX}" INTERFACE_INCLUDE_DIRECTORIES "${NANOARROW_FLATCC_INCLUDE_DIR}") endif() ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
