abtom87 commented on code in PR #49813:
URL: https://github.com/apache/arrow/pull/49813#discussion_r3411637375
##########
cpp/src/gandiva/gdv_string_function_stubs.cc:
##########
@@ -751,6 +800,11 @@ const char* translate_utf8_utf8_utf8(int64_t context,
const char* in, int32_t in
break;
}
+ // Updating len to char in this position
+ len_char_from = gdv_fn_utf8_char_length(from[from_for]);
+ // Making copy to std::string with length for this char position
+ std::string copy_from_compare(from + from_for, len_char_from);
+
Review Comment:
@kou I am not sure why this was moved down but i will move it to where it
was placed originally, and i will not do this change because this was not part
of the changes i did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
