Copilot commented on code in PR #49849:
URL: https://github.com/apache/arrow/pull/49849#discussion_r3411780454
##########
python/pyarrow/tests/test_dlpack.py:
##########
@@ -55,6 +55,8 @@ def wrapper(*args, **kwargs):
return wrapper
+# Asan tests are flacky on check_bytes_allocated assertion.
[email protected]
Review Comment:
Spelling: “flacky” should be “flaky” (and conventionally “ASan” capitalized)
in this comment.
##########
python/CMakeLists.txt:
##########
@@ -158,7 +158,12 @@ if(NOT DEFINED ARROW_RUNTIME_SIMD_LEVEL)
"MAX"
CACHE STRING "Max runtime SIMD optimization level")
endif()
+
+option(ARROW_USE_ASAN "Enable Address Sanitizer checks" OFF)
+option(ARROW_USE_UBSAN "Enable Undefined Behavior sanitizer checks" OFF)
+
include(SetupCxxFlags)
+include(san-config)
Review Comment:
Including san-config.cmake requires ARROW_USE_TSAN and ARROW_USE_COVERAGE to
be defined; otherwise `if(${ARROW_USE_TSAN})` / `if(${ARROW_USE_COVERAGE})` in
san-config expands to `if()` and CMake configure fails. Define these options
(OFF by default) before `include(san-config)` to keep non-sanitizer builds
working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
