pitrou commented on code in PR #41128: URL: https://github.com/apache/arrow/pull/41128#discussion_r3419219738
########## cpp/src/arrow/memory_pool_benchmark.cc: ########## @@ -17,6 +17,7 @@ #include "arrow/memory_pool.h" #include "arrow/result.h" +#include "arrow/util/config.h" Review Comment: The problem is that `arrow/util/config.h.cmake` is using [`cmakedefine`](https://cmake.org/cmake/help/latest/command/configure_file.html#transformations) which lets those variables undefined if the respective allocators are not enabled. It might have been better to use `cmakedefine01` instead, but this would break compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
