clee704 commented on code in PR #50183:
URL: https://github.com/apache/arrow/pull/50183#discussion_r3422805928
##########
cpp/src/parquet/statistics.cc:
##########
@@ -357,7 +389,9 @@ CleanStatistic(std::pair<T, T> min_max,
LogicalType::Type::type) {
return ::std::nullopt;
}
- if (min == std::numeric_limits<T>::max() && max ==
std::numeric_limits<T>::lowest()) {
Review Comment:
In practice there's no change or this is better. When min/max is set, both
are set always and it's always min <= max. This change also catches an invalid
SetMinMax call that sets min > max. So it's a better guard than before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
