etseidl commented on code in PR #10149:
URL: https://github.com/apache/arrow-rs/pull/10149#discussion_r3429072901
##########
parquet/src/file/metadata/thrift/mod.rs:
##########
@@ -1438,6 +1433,8 @@ impl<'a> WriteThrift for FileMeta<'a> {
#[allow(unused_assignments)]
fn write_thrift<W: Write>(&self, writer: &mut
ThriftCompactOutputProtocol<W>) -> Result<()> {
writer.set_write_path_in_schema(self.write_path_in_schema);
+ // only write ordinal if all values will fit in an i16
Review Comment:
That is easier, but I think it's odd to write some but not all. Also,
`OrdinalAssigner::ensure` will error if early row groups have ordinal set but
later row groups do not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
