alamb opened a new pull request, #764:
URL: https://github.com/apache/arrow-rs-object-store/pull/764

   # Which issue does this PR close?
   
   Follow-on documentation polish for the pluggable crypto work in #707. Does 
not close an issue, but relates to the testing/docs follow-ups tracked in #759 
and #760.
   
   # Rationale for this change
   
   While reviewing #707 (Pluggable Crypto / reqwest 0.13) after merge, two 
small documentation issues stood out:
   
   1. `object_store`'s `aws-lc-rs` feature deliberately does **not** select an 
`aws-lc-rs` backend (`aws-lc-sys` / `fips` / `non-fips`), so that downstream 
crates retain control over that choice. As a result, enabling `aws-lc-rs` 
together with a `*-base` feature but *without* the built-in `reqwest` transport 
fails to compile until the user selects a backend. This was non-obvious and not 
documented.
   2. A comment in `ci.yml` had a broken issue link (`https://githubcom/...`, 
missing the `.`).
   
   # What changes are included in this PR?
   
   - Add a note to the Cryptography section of the crate docs explaining that 
the `aws-lc-rs` feature requires the user to also select an `aws-lc-rs` backend 
when the built-in `reqwest` transport is not enabled.
   - Fix the malformed `https://github.com/...` URL in the CI comment that 
points at the testing-improvements issue (#759).
   
   Both are comment/documentation-only changes; no code or behavior is affected.
   
   # Are there any user-facing changes?
   
   Documentation only — clarifies an existing feature-flag requirement. No API 
or behavior changes, and nothing breaking.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to