pitrou commented on PR #48217: URL: https://github.com/apache/arrow/pull/48217#issuecomment-4739894561
> My main concern is test coverage. The existing `TestRoundtrip` tests only assert that encode → decode is self-consistent. On big-endian, a missing byte reversal cancels out across that round-trip, so the bug stays hidden +1 Besides testing the actual encoding output, I think we should set up a test module of integration tests using the data files from `parquet-testing`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
