projjal commented on a change in pull request #10068:
URL: https://github.com/apache/arrow/pull/10068#discussion_r631009398
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -381,6 +381,7 @@ CAST_NUMERIC_FROM_STRING(double, arrow::DoubleType, FLOAT8)
GDV_FN_CAST_VARCHAR_INTEGER(int32, Int32Type)
GDV_FN_CAST_VARCHAR_INTEGER(int64, Int64Type)
+GDV_FN_CAST_VARCHAR_INTEGER(date64, Date64Type)
Review comment:
Ok ignore REAL part, looks like the formatter is different for both the
types. Just rename from GDV_FN_CAST_VARCHAR_INTEGER to
GDV_FN_CAST_VARCHAR_FROM_TYPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
