lidavidm commented on PR #4397: URL: https://github.com/apache/arrow-adbc/pull/4397#issuecomment-4761385994
I believe HotSpot/OpenJDK is not affected by this. https://bugs.openjdk.org/browse/JDK-8297106 > In practice, in Hotspot, the actual functionality of EnsureLocalcapacity is a no-op: there is no inherent local ref capacity limit: we create them till we run out of memory. So the Xcheck:jni version of EnsureLocalCapacity is just a way to encourage people to write portable JNI code, in case it runs on a VM that does have a limit. It appears neither is Android, after 8.0: https://developer.android.com/ndk/guides/jni-tips > In Android versions prior to [Android 8.0](https://developer.android.com/about/versions/oreo), the number of local references is capped at a version-specific limit. Beginning in Android 8.0, Android supports unlimited local references. So we would need to test a JVM implementation that isn't derived from OpenJDK, that isn't Android; I believe this is very very few implementations. I can't find any reference to a limit for GraalVM, either. At this point the only other implementation I can think of is CheerpJ, but I don't think we support that in principle in the first place, so... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
