fallintoplace commented on code in PR #10175:
URL: https://github.com/apache/arrow-rs/pull/10175#discussion_r3448954255
##########
arrow-select/src/interleave.rs:
##########
@@ -95,6 +95,8 @@ pub fn interleave(
return Ok(new_empty_array(data_type));
}
+ validate_interleave_indices(values, indices)?;
Review Comment:
That makes sense. Would you prefer making this optional, similar to `take`
bounds checking, or keeping the fast path unchanged and documenting that
invalid indices may panic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
